Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix some problems related to flen #27677

Merged
merged 16 commits into from
Sep 15, 2021
Merged

expression: fix some problems related to flen #27677

merged 16 commits into from
Sep 15, 2021

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Aug 30, 2021 •
edited
Loading

What problem does this PR solve?

Fix some flen problems.

What is changed and how it works?

  1. Introduce DecimalLength2Precision() and Precision2LengthNoTruncation() to fix flen for the precision of div.
  2. Fix wrong calculation for concatWS.
  3. Fix flen for sysDate().

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

 'None'

wjhuang2016 and others added 3 commits August 30, 2021 16:21
@wjhuang2016
save
b805f24 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@SunRunAway @wjhuang2016
1
67f9adb 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
test
41407e1 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 30, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lzmhhh123
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 30, 2021
@wjhuang2016 wjhuang2016 changed the title *: fix some problem related to flen and notNulFlag *: fix some problems related to flen and notNulFlag Aug 30, 2021
@wjhuang2016
fix
aba91c2 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
done
30c81b9 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
Merge branch 'master' of github.com:pingcap/tidb into fix_flenxxxx
7755347
@wjhuang2016
refine
b13618b 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wshwsh12 wshwsh12 self-requested a review September 1, 2021 08:21
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 10, 2021
@wjhuang2016
fix
030cef0 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 10, 2021
@wjhuang2016 wjhuang2016 changed the title *: fix some problems related to flen and notNulFlag *: fix some problems related to flen Sep 10, 2021
lzmhhh123
lzmhhh123 reviewed Sep 13, 2021
View reviewed changes
types/helper.go Outdated Show resolved Hide resolved
@lzmhhh123 lzmhhh123 changed the title *: fix some problems related to flen expression: fix some problems related to flen Sep 13, 2021
@wjhuang2016
fix typo
cfb49f4 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
Merge branch 'fix_flenxxxx' of github.com:wjhuang2016/tidb into fix_f…
e77160e 
…lenxxxx
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 13, 2021
wshwsh12
wshwsh12 reviewed Sep 14, 2021
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

expression/builtin_cast.go Outdated
Comment on lines 1899 to 1901
if tp.Flen < 10 {
tp.Flen = 10
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't understand why we need add the check... Could your give me an example?

types/field_type.go
@@ -293,6 +293,8 @@ func DefaultTypeForValue(value interface{}, tp *FieldType, char string, collate
tp.Tp = mysql.TypeNewDecimal
tp.Flen = len(x.ToString())
tp.Decimal = int(x.digitsFrac)
// Add the length for `.`.
tp.Flen++
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x.ToString() have contained the ".", I think..

@wjhuang2016
test1
226428e 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
test
3b93739 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
Merge branch 'master' into fix_flenxxxx
080a1f4
@wjhuang2016
Copy link
Member Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 15, 2021
@wjhuang2016
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 080a1f4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 15, 2021
@ti-chi-bot
Copy link
Member

@wjhuang2016: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 83445d6 into pingcap:master Sep 15, 2021
@wjhuang2016 wjhuang2016 deleted the fix_flenxxxx branch November 17, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees
No one assigned
Labels
component/expression release-note-none Denotes a PR that doesn't merit a release note. sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wjhuang2016 @ti-chi-bot @wshwsh12 @lzmhhh123 @SunRunAway